Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(config)!: remove deprecated timeouts from config #755

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Mar 11, 2024

Issue being fixed or feature implemented

Multiple fields in the consensus config file are marked as deprecated for quite a long time.

What was done?

Removed deprecated fields:

  • DeprecatedTimeoutPropose
  • DeprecatedTimeoutProposeDelta
  • DeprecatedTimeoutPrevote
  • DeprecatedTimeoutPrevoteDelta
  • DeprecatedTimeoutPrecommit
  • DeprecatedTimeoutPrecommitDelta
  • DeprecatedTimeoutCommit
  • DeprecatedSkipTimeoutCommit

How Has This Been Tested?

Github Actions

Breaking Changes

The following fields are removed from config:

  • timeout-propose
  • timeout-propose-delta
  • timeout-prevote
  • timeout-prevote-delta
  • timeout-precommit
  • timeout-precommit-delta
  • timeout-commit
  • skip-timeout-commit

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lklimek lklimek merged commit 66fa34f into v0.14-dev Mar 12, 2024
15 checks passed
@lklimek lklimek deleted the refactor/remove-deprecated-config-options branch March 12, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants